Review

Review can do only person authorized previously by superior. List of authorized persons is below.

And false point in checklist means return of task to assignee.
It is unnecessary to go in order of sub-points and can be looked at multiple points at once.
It is good to read points as questions to see if they succeed in that question or not.

Review checklist

• Brief on task

• Check if branch matches changes master branch or has its commits

• General check
  (check and on first problem force assignee to check all related things. For example, if some padding is wrong, then tell him to check all paddings)

Code checklist

• Check relevant number of changes. Look for not properly looking number of changes against size of task

• Check code for proper and meaningful comments

• Check code for readability and cleanness

• Check out code structure and standards compliance. In case of deviation from our structure, recognize its size; in case of bigger deviation, consult it with superior (deviation size examples and their possible solutions are below)

• Check out if code is DRY (don't repeat yourself)

• Check code for unnecessary logs

• Check code for unwanted QLs (database query in loops)

Visual checklist

• Run up project and add dummy data if needed to see visually properly

• See all parts of task

• Check visual against graphics if some (use ruler or any other measuring tool to see if correct in dimensions)

• Try to break interactive things (buttons, form, …)

E-shop related checklist

• Check ability to add product into cart (check multiple variants if possible)

• Try to do at least 2 orders with different products and at least once with product with variants (if possible). Check out for proper output of order.

• Try special transportation options in first step of ordering (try parcelshop selects, etc.) with going to next step after selecting

• Check out cart at header for proper functionality

• If related, check out payment flow (try to order via payment gateway or via QR code, …)

• If related, check out analytics plugins and conversions for proper working (dataLayer to be correctly in console with all expecting data of order, …)

Coding related checklist

• If related, check for production compilation of JS/CSS code

• Check out accessibility of code

• Check out responsiveness of different dimensions

After merge

• Check related webpages on production

After checklist

• Reviewer should write proper feedback for the assignee.

• If not needed otherwise, reviewer should merge branch and report to client that task is done.

Standard process of authorizing new employee

• New person must know project's core structure and know standards used in company (see standards document).

• Person will be reviewing code first with superior, after that person will be doing it alone and that will be then reviewed by superior.

• After that, person will be authorized to do reviews.

Authorized

• Lukáš Žďárský

• Marek Tichý

• Jakub Jányš

• Dominik Šlechta